On Thu, Jan 25, 2024 at 01:05:06PM -0800, Bjorn Andersson wrote: > Due to the different PMIC configuration found in the SA8295P platform, > compared to SC8280XP, the VDD_GFX pads are supplied by an dedicated > MAX20411 LDO. > > Support for expressing the regulator supply is added to the binding, the > support for enabling the parent supply for GX is added, the missing > gfx.lvl power-domain is dropped, and the DeviceTree is wired up to > enable the GPU in this configuration. > > Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> Sorry, I forgot to change the subject prefix of the rpmhpd patch, and pick up Konrad's two r-b. Regards, Bjorn > --- > Changes in v4: > - Updated qcom,gpucc.yaml binding check that both power-domains and > vdd-gfx-supply isn't used together. Updated related comment as well. > - Link to v3: https://lore.kernel.org/r/20240123-sa8295p-gpu-v3-0-d5b4474c8f33@xxxxxxxxxxx > > Changes in v3: > - Removed one unnecessary empty line in DT node > - Rebased series to v6.8-rc1 > - Link to v2: https://lore.kernel.org/r/20231220-sa8295p-gpu-v2-0-4763246b72c0@xxxxxxxxxxx > > Changes in v2: > - Made gpucc binding accept either power-domain or vdd-gfx-supply > - Updated comment in gdsc_gx_do_nothing_enable() > - Added a comment for the /delete-property/ power-domains > - Fixed node and property sort order in dts > - Switched zap firmware to use mbn file > - Link to v1: https://lore.kernel.org/r/20231220-sa8295p-gpu-v1-0-d8cdf2257f97@xxxxxxxxxxx > > --- > Bjorn Andersson (8): > dt-bindings: clock: qcom: Allow VDD_GFX supply to GX > clk: qcom: gdsc: Enable supply reglator in GPU GX handler > clk: qcom: gpucc-sc8280xp: Add external supply for GX gdsc > soc: qcom: rpmhpd: Drop SA8540P gfx.lvl > arm64: dts: qcom: sa8540p: Drop gfx.lvl as power-domain for gpucc > arm64: dts: qcom: sa8295p-adp: add max20411 > arm64: dts: qcom: sa8295p-adp: Enable GPU > arm64: defconfig: Enable MAX20411 regulator driver > > .../devicetree/bindings/clock/qcom,gpucc.yaml | 9 +++ > arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 68 ++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/sa8540p.dtsi | 3 + > arch/arm64/configs/defconfig | 1 + > drivers/clk/qcom/gdsc.c | 12 +++- > drivers/clk/qcom/gpucc-sc8280xp.c | 1 + > drivers/pmdomain/qcom/rpmhpd.c | 1 - > 7 files changed, 92 insertions(+), 3 deletions(-) > --- > base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d > change-id: 20231220-sa8295p-gpu-51c5f343e3ec > > Best regards, > -- > Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> >
