Re: [PATCH v4 3/3] ARM: dts: aspeed: System1: IBM system1 BMC board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Bjorn,

On 1/16/24 13:03, Bjorn Helgaas wrote:
On Tue, Jan 16, 2024 at 12:37:34PM -0600, Ninad Palsule wrote:
From: Andrew Geissler <geissonator@xxxxxxxxx>

Add a device tree for IBM system1 BMC board. It uses AST2600 SOC.
- Added base board
s/Added/Add/ to match first sentence.
Fixed

- Added i2c devices and muxes.
- Added different voltage regulators.
- Added GPIO pin assignements, GPIO expansion devices
- Added LED brinker devices
"brinker"?  "blinker" maybe (no idea what it actually is).
Fixed. Its blinker.
- Added Fan controllers
s/Fan/fan/
Fixed.

- Added EEPROM/VPD
- Added Power supplies
s/Power/power/
Fixed.

- Added Humidity, pressure and temperature sensors.
s/Humidity/humidity/
Fixed.

- Added Trusted platform module(TPM) chip.
s/Trusted platform module/Trusted Platform Module /
Fixed

Tested:
     This board is tested using the simics simulator.

Signed-off-by: Ninad Palsule <ninad@xxxxxxxxxxxxx>
Signed-off-by: Andrew Geissler <geissonator@xxxxxxxxx>
Your sign-off should be last since you are sending the series.

Fixed.

Thanks for the review.

Regards,

Ninad Palsule






[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux