On 15:02-20240125, Chintan Vankar wrote: > > On 19/01/24 18:48, Nishanth Menon wrote: > > On 15:14-20240118, Chintan Vankar wrote: > > > From: Siddharth Vadapalli<s-vadapalli@xxxxxx> > > > > > > J784S4 SoC has a Main CPSW2G instance of the CPSW Ethernet Switch. > > > > > > Add the device-tree nodes for the Main CPSW2G instance and enable it. > > > > > > Signed-off-by: Siddharth Vadapalli<s-vadapalli@xxxxxx> > > > Signed-off-by: Jayesh Choudhary<j-choudhary@xxxxxx> > > > Signed-off-by: Chintan Vankar<c-vankar@xxxxxx> > > > --- > > > arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 47 +++++++++++++++ > > > arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 68 ++++++++++++++++++++++ > > > 2 files changed, 115 insertions(+) > > Please do not mix the SoC and evm changes in the same patch. > Okay. I will separate them in the v3 series > > Also, any benefits of giving the second instance an alias? > > Yes, there are benefits of adding an alias, > > I will add aliases for both Main and MCU cpsw2g, > > and post it in a future series. If there is benefit, squash to current patch. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
