Re: [PATCH v2 1/2] arm64: dts: qcom: sm8650-mtp: add PM8010 regulators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 1/25/24 03:52, David Collins wrote:
On 1/24/24 15:36, Konrad Dybcio wrote:
On 1/24/24 20:15, David Collins wrote:
On 1/23/24 00:49, Fenglin Wu via B4 Relay wrote:
From: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>

Add PM8010 regulator device nodes for sm8650-mtp board.

Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
Signed-off-by: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
...
+
+        vreg_l1m_1p1: ldo1 {
+            regulator-name = "vreg_l1m_1p1";
+            regulator-min-microvolt = <1104000>;
+            regulator-max-microvolt = <1104000>;
+            regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;

Optional:
PM8010 L1 and L2 physically support LPM vs HPM configuration.
Therefore, these lines could be added here to allow such configuration
by software at runtime:

regulator-allow-set-load;
regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
                RPMH_REGULATOR_MODE_HPM>;

David,

I was under the impression that *all* RPMh regulators support
modesetting. Would that be an incorrect assumption to make?

Konrad

Hello Konrad,

That is generally true.  However, PM8010 LDOs 3-7 are a special case.
These do not support LPM configuration.  The limitation is enforced in
the driver by this change:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2544631faa7f3244c9bcb9b511ca4f1a4f5a3ba0

Oh, I never noticed that. Thanks a lot for confirming!

Konrad




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux