On 1/25/24 10:27, Abel Vesa wrote:
The Disp AHB clock is provided by the GCC but never registered. It is instead enabled on probe as it is expected to be always-on. So it should be dropped from Disp CC entirely. Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> ---
Abel, you just raised some concerns over my series doing this and now you're doing the same, plus breaking backwards compatibility for no good reason, instead of solving the problem. The correct solution here is to register the AHB clock with GCC and pm_clk_add() it from dispcc's .probe (and enable runtime PM on dispcc if it's already not the case). Then the AHB clock will be gated when no display hardware (= no dispcc consumer) is in use. 8[56]50 are in a good position for this, as they already have the required DTS reference. Unfortunately, I still haven't fully dug into this for platforms without one, but that's on me. Konrad
