On 25/01/2024 09:46, Ding, Shenghao wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> Sent: Thursday, January 25, 2024 3:50 PM >> To: Ding, Shenghao <shenghao-ding@xxxxxx>; broonie@xxxxxxxxxx; >> conor+dt@xxxxxxxxxx >> Cc: robh+dt@xxxxxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx; Lu, Kevin >> <kevin-lu@xxxxxx>; Xu, Baojun <baojun.xu@xxxxxx>; >> devicetree@xxxxxxxxxxxxxxx; lgirdwood@xxxxxxxxx; perex@xxxxxxxx; >> pierre-louis.bossart@xxxxxxxxxxxxxxx; 13916275206@xxxxxxx; linux- >> sound@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >> liam.r.girdwood@xxxxxxxxx; soyer@xxxxxx; Huang, Jonathan >> <jkhuang3@xxxxxx>; tiwai@xxxxxxx; Djuandi, Peter <pdjuandi@xxxxxx>; >> McPherson, Jeff <j-mcpherson@xxxxxx>; Navada Kanyana, Mukund >> <navada@xxxxxx> >> Subject: Re: [EXTERNAL] Re: [PATCH v1 4/4] ASoc: dt-bindings: Create yaml >> file for pcm6240 codec driver >> >> On 25/01/2024 08: 39, Ding, Shenghao wrote: >> >> Why do you repeat the >> reg constraints? This does not seem needed. >> >>> + interrupts: false >>> >> + >>> + - if: >>> + properties: >>> ZjQcmQRYFpfptBannerStart This message >> was sent from outside of Texas Instruments. >> Do not click links or open attachments unless you recognize the source of >> this email and know the content is safe. >> >> ZjQcmQRYFpfptBannerEnd >> On 25/01/2024 08:39, Ding, Shenghao wrote: >>>> >>>> Why do you repeat the reg constraints? This does not seem needed. >>>> >>>>> + interrupts: false >>>>> + >>>>> + - if: >>>>> + properties: >>>>> + compatible: >>>>> + contains: >>>>> + enum: >>>>> + - ti,pcm3140 >>>>> + - ti,pcm5140 >>>>> + - ti,pcm6140 >>>>> + - ti,pcmd3180 >>>>> + then: >>>>> + properties: >>>>> + reg: >>>>> + description: >>>>> + I2C address, in multiple pcmdevices case, all the i2c address >>>>> + aggregate as one Audio Device to support multiple audio slots. >>>>> + maxItems: 4 >>>>> + minItems: 1 >>>> >> >> You did not respond to any of other comments, therefore I assume you >> agree with them 100% and you will implement them fully. >> >> >>>> Drop entire if >>> How to convey ti,pcm1690 does not support interrupt, and others >>> support if I remove this if >> >> How? There is no pcm1690 here. > How can others know that pcm3140, pcm5140, pcm6140 and pcmd3180 > Support i2c address from 0x4c to 0x4f, if this if branch was removed. They do not need anything to support any specific I2C address... If ever wondering, open some recent bindings and take a look how it is done there. Best regards, Krzysztof
