Re: [PATCH] ARM: dts: stm32: lxa-tac: drive powerboard lines as open-drain

[Alexandre TORGUE <alexandre.torgue@xxxxxxxxxxx>]

On 1/24/24 11:01, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Oct 18, 2023 at 10:31:55PM +0200, Uwe Kleine-König wrote:
> > From: Leonard Göhrs <l.goehrs@xxxxxxxxxxxxxx>
> >
> > This results in a slight improvement in EMI performance due to the lines
> > no longer being driven by the somewhat noisy VDD_IO supply of the SoM.
> >
> > Signed-off-by: Leonard Göhrs <l.goehrs@xxxxxxxxxxxxxx>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts | 2 +-
> >   arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi     | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts b/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts
> > index 8a34d15e9005..4cc177031661 100644
> > --- a/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts
> > +++ b/arch/arm/boot/dts/st/stm32mp157c-lxa-tac-gen2.dts
> > @@ -148,7 +148,7 @@ adc@0 {
> >   		compatible = "ti,lmp92064";
> >   		reg = <0>;
> >   
> > -		reset-gpios = <&gpioa 4 GPIO_ACTIVE_HIGH>;
> > +		reset-gpios = <&gpioa 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> >   		shunt-resistor-micro-ohms = <15000>;
> >   		spi-max-frequency = <5000000>;
> >   		vdd-supply = <&reg_pb_3v3>;
> > diff --git a/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi b/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
> > index f09b7c384bd9..188c9cfc7102 100644
> > --- a/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
> > +++ b/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi
> > @@ -409,7 +409,7 @@ &sdmmc2 {
> >   &spi2 {
> >   	pinctrl-names = "default";
> >   	pinctrl-0 = <&spi2_pins_c>;
> > -	cs-gpios = <&gpiof 12 GPIO_ACTIVE_LOW>;
> > +	cs-gpios = <&gpiof 12 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
> >   	status = "okay";
> >   };
> >   
> >
> > base-commit: 4d5ab2376ec576af173e5eac3887ed0b51bd8566
>
> Gentle ping. Given this patch is two months old now I assume it fell
> through the cracks?

Yes, apologize for that.

Applied on stm32-next.

Cheers
Alex

> Best regards
> UWe