Hi all, thank you for your input so far.
On 1/23/24 12:15, Roger Quadros wrote:
Hello Diogo,
On 17/01/2024 18:14, Diogo Ivo wrote:
Hello,
This series extends the current ICSSG-based Ethernet driver to support
Silicon Revision 1.0 devices.
Notable differences between the Silicon Revisions are that there is
no TX core in SR1.0 with this being handled by the firmware, requiring
extra DMA channels to communicate commands to the firmware (with the
firmware being different as well) and in the packet classifier.
The motivation behind it is that a significant number of Siemens
devices containing SR1.0 silicon have been deployed in the field
and need to be supported and updated to newer kernel versions
without losing functionality.
Adding SR1.0 support with all its ifdefs makes the driver more complicated
than it should be.
I think we need to treat SR1.0 and SR2.0 as different devices with their
own independent drivers. While the data path is pretty much the same,
also like in am65-cpsw-nuss.c, the initialization, firmware and other
runtime logic is significantly different.
How about introducing a new icssg_prueth_sr1.c and putting all the SR1 stuff
there? You could still re-use the other helper files in net/ti/icssg/.
It also warrants for it's own Kconfig symbol so it can be built only
if required.
Any common logic could still be moved to icssg_common.c and re-used in both drivers.
Yes, that sounds like a more reasonable approach. I will refactor the code
and come back with a v3, hopefully with all patches getting sent out :)
Best regards,
Diogo
