On Wed 24 Jan 2024 at 10:08, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> [[PGP Signed Part:Undecided]]
> Hello Jerome,
>
> On Fri, Dec 22, 2023 at 12:16:51PM +0100, Jerome Brunet wrote:
>> Meson8 pwm type always has 4 input clocks. Some inputs may be grounded,
>> like in the AO domain of some SoCs.
>>
>> Drop the parent number parameter and make this is constant.
>> This is also done to make addition of generic meson8 compatible easier.
>>
>> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
>> ---
>> drivers/pwm/pwm-meson.c | 19 ++++++-------------
>> 1 file changed, 6 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
>> index 2971bbf3b5e7..ef50c337f444 100644
>> --- a/drivers/pwm/pwm-meson.c
>> +++ b/drivers/pwm/pwm-meson.c
>> @@ -60,7 +60,7 @@
>> #define MISC_A_EN BIT(0)
>>
>> #define MESON_NUM_PWMS 2
>> -#define MESON_MAX_MUX_PARENTS 4
>> +#define MESON_NUM_MUX_PARENTS 4
>>
>> static struct meson_pwm_channel_data {
>> u8 reg_offset;
>> @@ -98,7 +98,6 @@ struct meson_pwm_channel {
>>
>> struct meson_pwm_data {
>> const char * const *parent_names;
>
> I suggest to make this
>
> const char *parent_names[MESON_NUM_MUX_PARENTS];
Ok.
>
> to make it more explicit that really four entries are needed here. This
> also makes is unnecessary to add the additional NULL entries to
> pwm_gxbb_ao_parent_names and the other arrays.
I would normally agree but I'd prefer to be explicit.
There are some instance where the NULL is in the middle, this can't go
away. I think it looks if some inputs are explicitly NULL while the
other are implicit.
Of course, it is just a preference. I can remove these if that is
bothering you.
>
> Best regards
> Uwe
--
Jerome
