Re: [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet

[Priit Laes <plaes@xxxxxxxxx>]

On Fri, 2015-01-23 at 22:22 +0100, Maxime Ripard wrote:
> On Fri, Jan 23, 2015 at 10:36:49PM +0200, Priit Laes wrote:
> > Gemei G9 is an A10 based tablet, with 1G RAM, 16G NAND, 1024x768 
> > IPS LCD display, stereo speakers, 1.3MP front camera and 5 MP
> > rear camera, 8000mAh battery, GT901 2+1 touchscreen, Bosch BMA250 
> > accelerometer and RTL8188CUS USB wifi. It also has MicroSD slot, 
> > miniHDMI, 1 x MicroUSB OTG port and 1 x MicroUSB host port and 
> > 3.5mm headphone jack.
> > More details are available at: http://linux-sunxi.org/Gemei_G9
> > 
[..]
> > 
> > +/ {
> > +    model = "Gemei G9 Tablet";
> > +    compatible = "gemei,g9", "allwinner,sun4i-a10";
> > +};
> > +
> > +/*
> > + * http://linux-sunxi.org/Gemei_G9
> 
> Please don't put URL in the DT. This is very likely to change in the 
> future, and won't be valid anymore.

OK! The URL in commit message is ok to stay?
> 
> > + *
> > + * TODO:
> > + *   2x cameras via CSI
> > + *   AXP battery management
> > + *   AXP power enable key
> > + *   Keys (LRADC)
> > + *   NAND
> > + *   OTG
> > + *   Touchscreen - gt801_2plus1 @ i2c adapter 2 @ 0x48
> > + */
> > +
> > +
> > +&ehci0 {
> > +    status = "okay";
> > +};
> 
> Indentation with one tabulation please.

Oops.. will do.
> 
> 
> > +&ehci1 {
> > +    status = "okay";
> > +};
> > +
> > +&i2c0 {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&i2c0_pins_a>;
> > +    status = "okay";
> > +
> > +    axp209: pmic@34 {
> > +        compatible = "x-powers,axp209";
> > +        reg = <0x34>;
> > +        interrupts = <0>;
> > +
> > +        interrupt-controller;
> > +        #interrupt-cells = <1>;
> > +    };
> > +};
> > +
> > +&i2c1 {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&i2c1_pins_a>;
> > +    status = "okay";
> > +
> > +    /* Accelerometer */
> > +    bma250@18 {
> > +        compatible = "bosch,bma250";
> > +        reg = <0x18>;
> 
> Is there a driver for this? It looks weird that it doesn't need more 
> properties than that.

Yes, it's supported by drivers/iio/accel/bma180.c though I have to 
admit that this name is a bit misleading. (bosch-bma.c would 
better, I guess).

And I was a bit surprised that it worked out of the box too, but the 
device was present under /sys and I was able to read x, y, z and 
temperature values.

> > +    };
> > +};
> > +
> > +&reg_usb1_vbus {
> > +    status = "okay";
> > +};
> > +
> > +&reg_usb2_vbus {
> > +    status = "okay";
> > +};
> > +
> > +&mmc0 {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_reference_design>;
> > +    vmmc-supply = <&reg_vcc3v3>;
> > +    bus-width = <4>;
> > +    cd-gpios = <&pio 7 1 GPIO_ACTIVE_HIGH>; /* PH01 */
> > +    cd-inverted;
> > +    status = "okay";
> > +};
> > +
> > +
> 
> Remove that extra new line.

Will do.
> 
> > +&uart0  {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&uart0_pins_a>;
> > +    status = "okay";
> > +};
> > +
> > +&usbphy {
> > +    usb1_vbus-supply = <&reg_usb1_vbus>;
> > +    usb2_vbus-supply = <&reg_usb2_vbus>;
> > +    status = "okay";
> > +};
> > --
> > 2.2.2
> > 
> 
> Looks good otherwise, thanks! Maxime
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html