Re: [PATCH v2 3/5] dt-bindings: memory: additional compatible strings for Broadcom DPFE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19/01/2024 22:52, Markus Mayer wrote:
> Add versioned compatible strings for Broadcom DPFE. These take the form
> brcm,dpfe-cpu-v<N> where <N> is a number from 1 to 4.
> 
> The chip-specific strings have been kept for compatibility purposes
> (hardware is in the field). For new chips, the properly versioned
> compatible string should be used.
> 
> Signed-off-by: Markus Mayer <mmayer@xxxxxxxxxxxx>
> ---
>  .../memory-controllers/brcm,dpfe-cpu.yaml     | 21 ++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml b/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml
> index 3f00bc2fd3ec..42c8160d95d1 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml
> @@ -10,9 +10,28 @@ maintainers:
>    - Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>    - Markus Mayer <mmayer@xxxxxxxxxxxx>
>  
> +description: |
> +

Drop blank line.

> +  The DCPU (DDR PHY Front End CPU) interfaces directly with the DDR PHY
> +  chip on Broadcom STB SoCs. An API exists for other agents to retrieve
> +  or set certain DDR PHY chip parameters by JEDEC.
> +
> +  Different, incompatible versions of this API have been created over
> +  time. The API has changed for the some chips as development progressed
> +  and features were added or changed.
> +
> +  We rely on the boot firmware (which already knows the API version
> +  required) to populate Device Tree with the corresponding compatible
> +  string.
> +
>  properties:
>    compatible:
>      items:
> +      - enum:
> +          - brcm,dpfe-cpu-v1
> +          - brcm,dpfe-cpu-v2
> +          - brcm,dpfe-cpu-v3
> +          - brcm,dpfe-cpu-v4

I don't see my comment resolved - except more unusual order of
compatibles - and nothing in commit msg explains my previous concerns.

I think my final comment was pretty clear yet ignored completely. There
was no follow up:
https://lore.kernel.org/all/3fff866f-fbe8-4d23-87f3-275380adf3d4@xxxxxxxxxx/

so with ignored comments: NAK



Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux