Re: [PATCH v2 1/5] dt-bindings: memory: remove generic compatible string brcm,dpfe-cpu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19/01/2024 22:52, Markus Mayer wrote:
> The generic compatible string "brcm,dpfe-cpu" is removed from the
> binding as it does not provide any actual benefit.
> 
> Signed-off-by: Markus Mayer <mmayer@xxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml  | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml b/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml
> index 08cbdcddfead..e2b990e4a792 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml
> @@ -16,7 +16,6 @@ properties:
>        - enum:
>            - brcm,bcm7271-dpfe-cpu
>            - brcm,bcm7268-dpfe-cpu
> -      - const: brcm,dpfe-cpu

We cannot have undocumented compatibles, so I think you wanted to
deprecate it instead. Also, please extend the reasoning from "any actual
benefit". Were there any users? Don't they need it?

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux