On Tue, Jan 23, 2024 at 9:34 AM Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote: > > Add missing blank line after declaration. Move initialization in the > body of the function. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> > --- > drivers/spi/spi-s3c64xx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index f5474f3b3920..2abf5994080a 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -1273,8 +1273,9 @@ static int s3c64xx_spi_suspend(struct device *dev) > { > struct spi_controller *host = dev_get_drvdata(dev); > struct s3c64xx_spi_driver_data *sdd = spi_controller_get_devdata(host); > + int ret; > > - int ret = spi_controller_suspend(host); > + ret = spi_controller_suspend(host); Why not just moving the empty line below the declaration block, keeping the initialization on the variable declaration line? > if (ret) > return ret; > > -- > 2.43.0.429.g432eaa2c6b-goog >