> Subject: Re: [PATCH v3 1/4] dt-bindings: mailbox: fsl,mu: add i.MX95 > Generic/ELE/V2X MU compatible > > On 23/01/2024 15:38, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@xxxxxxx> > > > > Add i.MX95 Generic, Secure Enclave and V2X Message Unit compatible > string. > > And some MUs has internal RAMs for SCMI shared buffer usage. > > > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > > --- > > .../devicetree/bindings/mailbox/fsl,mu.yaml | 50 > +++++++++++++++++++++- > > 1 file changed, 48 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > > b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > > index 12e7a7d536a3..569fabc5285c 100644 > > --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > > +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > > @@ -29,10 +29,14 @@ properties: > > - const: fsl,imx8ulp-mu > > - const: fsl,imx8-mu-scu > > - const: fsl,imx8-mu-seco > > - - const: fsl,imx93-mu-s4 > > - const: fsl,imx8ulp-mu-s4 > > + - const: fsl,imx93-mu-s4 > > + - const: fsl,imx95-mu-ele > > + - const: fsl,imx95-mu-v2x > > - items: > > - - const: fsl,imx93-mu > > + - enum: > > + - fsl,imx93-mu > > + - fsl,imx95-mu > > - const: fsl,imx8ulp-mu > > - items: > > - enum: > > @@ -95,6 +99,17 @@ properties: > > power-domains: > > maxItems: 1 > > > > + ranges: true > > + > > + "#address-cells": true > > + > > + "#size-cells": true > > + > > +patternProperties: > > + "^sram@[a-z0-9]+": > > This is a friendly reminder during the review process. > Oh, sorry, I overlooked this. Will send out v4 later, waiting to see whether Sascha has comments on the driver part. Thanks, Peng. > It seems my or otSher reviewer's previous comments were not fully addressed. > Maybe the feedback got lost between the quotes, maybe you just forgot to > apply it. Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > > Thank you. > > Best regards, > Krzysztof
