On 23-12-15 12:40:45, Bryan O'Donoghue wrote:
> On 14/12/2023 16:49, Abel Vesa wrote:
> > From: Rajendra Nayak <quic_rjendra@xxxxxxxxxxx>
> >
> > Add Graphics Clock Controller (GPUCC) support for X1E80100 platform.
> >
> > Signed-off-by: Rajendra Nayak <quic_rjendra@xxxxxxxxxxx>
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
>
> > +static struct platform_driver gpu_cc_x1e80100_driver = {
> > + .probe = gpu_cc_x1e80100_probe,
> > + .driver = {
> > + .name = "gpu_cc-x1e80100",
>
> I think these underscores are very unnecessary and subtractive of meaning.
>
> .name = "gpucc-x1e80100"
>
> > + .of_match_table = gpu_cc_x1e80100_match_table,
> > + },
> > +};
> > +module_platform_driver(gpu_cc_x1e80100_driver);
> > +
> > +MODULE_DESCRIPTION("QTI GPU_CC x1e80100 Driver");
>
> "QTI GPU Clock Controller Driver"
Again, please look at other platforms (SM8650, SM8550, etc).
>
> ---
> bod
