On 22/01/2024 07:19, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
>
> Add i.MX95 Generic, Secure Enclave and V2X Message Unit compatible string.
> And some MUs has internal RAMs for SCMI shared buffer usage.
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
> .../devicetree/bindings/mailbox/fsl,mu.yaml | 50 +++++++++++++++++++++-
> 1 file changed, 48 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> index 12e7a7d536a3..d10c6fed291b 100644
> --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> @@ -29,10 +29,14 @@ properties:
> - const: fsl,imx8ulp-mu
> - const: fsl,imx8-mu-scu
> - const: fsl,imx8-mu-seco
> - - const: fsl,imx93-mu-s4
> - const: fsl,imx8ulp-mu-s4
> + - const: fsl,imx93-mu-s4
> + - const: fsl,imx95-mu-ele
> + - const: fsl,imx95-mu-v2x
> - items:
> - - const: fsl,imx93-mu
> + - enum:
> + - fsl,imx93-mu
> + - fsl,imx95-mu
> - const: fsl,imx8ulp-mu
> - items:
> - enum:
> @@ -95,6 +99,17 @@ properties:
> power-domains:
> maxItems: 1
>
> + ranges: true
> +
> + "#address-cells": true
> +
> + "#size-cells": true
Please narrow the addressing.
> +
> +patternProperties:
> + "^sram@[a-z0-9]+":
Use proper regex for unit address. a-f
> + $ref: /schemas/sram/sram.yaml#
> + unevaluatedProperties: false
> +
> required:
> - compatible
> - reg
> @@ -134,3 +149,34 @@ examples:
> interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
> #mbox-cells = <2>;
> };
> +
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + mu2: mailbox@445b0000 {
> + #address-cells = <1>;
Please follow order of properties as written in DTS coding style.
> + #size-cells = <1>;
> + compatible = "fsl,imx95-mu", "fsl,imx8ulp-mu";
> + reg = <0x445b0000 0x10000>;
> + interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;
> + ranges;
> + #mbox-cells = <2>;
> +
> + sram@445b1000 {
> + compatible = "mmio-sram";
> + reg = <0x445b1000 0x400>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x445b1000 0x400>;
Same here.
Best regards,
Krzysztof
