On 22/01/2024 15:51, Rong Zhang wrote:
> I've glanced similar dts. To solve this, I think we could either:
> 1. keep the dt-binding in [PATCH 3/4], and delete "samsung,klte" here
> 2. rewrite dt-binding like crystalfontz,cfa100{36,37,49,55,56,57,58}:
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 2bd29a2399ad..4979ccae2b64 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -223,11 +223,17 @@ properties:
> - fairphone,fp2
> - oneplus,bacon
> - samsung,klte
> - - samsung,kltechn
> - sony,xperia-castor
> - const: qcom,msm8974pro
> - const: qcom,msm8974
>
> + - items:
> + - enum:
> + - samsung,kltechn
> + - const: samsung,klte
> + - const: qcom,msm8974pro
> + - const: qcom,msm8974
> +
> - items:
> - const: qcom,msm8916-mtp
> - const: qcom,msm8916-mtp/1
>
> My preference is (2.) since other variants of klte may be added in the
> future. I would like to hear your preferences.
It depends whether the devices are compatible. IOW, entire klte DTB
should work fine on kltechn, just without few new devices.
Best regards,
Krzysztof
