On 2024-01-22 12:48:27, AngeloGioacchino Del Regno wrote:
> Il 21/01/24 23:33, Marijn Suijten ha scritto:
> > In addition to the SDC2 pins, set the SD Card Detect pin in a sane state
> > to be used as an interrupt when an SD Card is slotted in or removed.
> >
> > Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi b/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi
> > index b0b83edd3627..75412e37334c 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi
> > @@ -264,10 +264,27 @@ &sdhc_1 {
> > status = "okay";
> > };
> >
> > +&sdc2_off_state {
> > + sd-cd-pins {
> > + pins = "gpio100";
> > + function = "gpio";
> > + drive-strength = <2>;
> > + bias-disable;
> > + };
>
> Are you sure that you really don't want card detect during system suspend?
Does it make a difference if the rest of pinctrl and the SDHCI controller are
also turned off?
> You could simply add a sdc2-cd-pins out of sdc2_{on,off}_state and add use it for
> both default and sleep.
This sounds close to what Konrad suggested by using a new block wit its own
label rather than extending the existing state.
> pinctrl-0 = <&sdc2_on_state>, <&sdc2_card_det_n>;
> pinctrl-1 = <&sdc2_off_state>;
You said both, but it's not in pinctrl-1 here? (And might unselect bias-pull-up
implicitly instead of explicitly selecting bias-disable via an off node?)
- Marijn
> Cheers,
> Angelo
>
> > +};
> > +
> > &sdc2_on_state {
> > clk-pins {
> > drive-strength = <10>;
> > };
> > +
> > + sd-cd-pins {
> > + pins = "gpio100";
> > + function = "gpio";
> > + drive-strength = <2>;
> > + input-enable;
> > + bias-pull-up;
> > + };
> > };
> >
> > &sdhc_2 {
> >
>
>
