On 17/01/24 1:07 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 17/01/2024 03:22, Dharma.B@xxxxxxxxxxxxx wrote: >> Hi Krzysztof, >> On 10/01/24 11:31 pm, Krzysztof Kozlowski wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> On 10/01/2024 11:25, Dharma Balasubiramani wrote: >>>> Convert the atmel,hlcdc binding to DT schema format. >>>> >>>> Signed-off-by: Dharma Balasubiramani <dharma.b@xxxxxxxxxxxxx> >>>> --- >>>> .../devicetree/bindings/mfd/atmel,hlcdc.yaml | 106 ++++++++++++++++++ >>>> .../devicetree/bindings/mfd/atmel-hlcdc.txt | 56 --------- >>>> 2 files changed, 106 insertions(+), 56 deletions(-) >>>> create mode 100644 Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml >>>> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml b/Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml >>>> new file mode 100644 >>>> index 000000000000..555d6faa9104 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml >>> >>> This looks not tested, so limited review follows: >> I acknowledge that I didn't test the patches individually. I appreciate >> your understanding. Taken care in v2. >>> >>>> @@ -0,0 +1,106 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>> +# Copyright (C) 2024 Microchip Technology, Inc. and its subsidiaries >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/mfd/atmel,hlcdc.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Atmel's HLCDC (High LCD Controller) MFD driver >>> >>> Drop "MFD driver" and rather describe/name the hardware. MFD is Linux >>> term, so I really doubt that's how this was called. >> Done. >>> >>>> + >>>> +maintainers: >>>> + - Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx> >>>> + - Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> >>>> + - Claudiu Beznea <claudiu.beznea@xxxxxxxxx> >>>> + >>>> +description: | >>>> + Device-Tree bindings for Atmel's HLCDC (High LCD Controller) MFD driver. >>> >>> Drop >> Done. >>> >>>> + The HLCDC IP exposes two subdevices: >>>> + # a PWM chip: see ../pwm/atmel,hlcdc-pwm.yaml >>>> + # a Display Controller: see ../display/atmel/atmel,hlcdc-dc.yaml >>> >>> Rephrase to describe hardware. Drop redundant paths. >> Sure, I will truncate this to "subdevices: a PWM chip and a display >> controller." & drop the |. >> >> I added description about those two subdevices below. > > Then why do you still keep there comments? # is a comment. Sure, I will drop the comments here. > ... > >> in v3. >>> >>>> + >>>> + hlcdc-display-controller: >>> >>> Does anything depend on the name? If not, then just display-controller >> Got an error "'hlcdc-display-controller' does not match any of the >> regexes: 'pinctrl-[0-9]+'" so I retained it in v2,but as conor advised >> to have node names generic and we can easily adopt, I will modify it in v3. > > That's not a dependency. I was talking about any users of the binding. > User of a binding is for example: Linux kernel driver, other open-source > projects, out-of-tree projects. Sure, I will go with generic names 'display-controller' and 'pwm'. -- With Best Regards, Dharma B. > > > Best regards, > Krzysztof >
