On Wed, Jan 17, 2024 at 05:03:20PM +0800, Chen Wang wrote: > > On 2023/11/13 8:57, Jisheng Zhang wrote: > > This series adds pinctrl support for cv1800b reusing the > > pinctrl-single driver. > > > > Jisheng Zhang (2): > > riscv: dts: cv1800b: add pinctrl node for cv1800b > > riscv: dts: sophgo: set pinctrl for uart0 > > > > arch/riscv/boot/dts/sophgo/cv-pinctrl.h | 19 +++++++++++++++++++ > > .../boot/dts/sophgo/cv1800b-milkv-duo.dts | 11 +++++++++++ > > arch/riscv/boot/dts/sophgo/cv1800b.dtsi | 10 ++++++++++ > > 3 files changed, 40 insertions(+) > > create mode 100644 arch/riscv/boot/dts/sophgo/cv-pinctrl.h > > One question, when we use "pinctrl-single" driver, should we enable > CONFIG_PINCTRL_SINGLE? Or just leave it to package vendor to configure by It's better to enable PINCTRL_SINGLE in defconfig. However, per recently pin related xls from milkv github repo, pinctrl-single isn't suitable.