Le dimanche 31 décembre 2023 à 23:11 +0800, Jianfeng Liu a écrit : > This is the v3 version of this series adding hantro g1 video decoder > support for rk3588. > > RK3588 has Hantro G1 video decoder known as VDPU121 in TRM of RK3588 which > is capable to decode MPEG2/H.264/VP8 up to 1920x1088. This vpu ip is also > found in RK3568. The only concern I have is that we rejected enabling this VPU on RK3399, since having two H.264 decoders was confusing userspace softwares at the time, causing the slow one to be picked sometimes. I know the selection is not fully implemented in GStreamer either, not sure for LibreELEC ffmpeg fork, Chromium or Cros-codec. Of course, its not a problem now, but only when someone provides an rkvdec2 driver that enables the much more capable HW decoder. Shall we hold on H.264 mainline for now ? Nicolas > > Test results from fluster can be found from thread of v2[1][2]. > > [1] https://lore.kernel.org/all/CAAXNxMT3f68-ptM7Crhrfmn7iwTyJc9pwz4Beob+5beVODaSHQ@xxxxxxxxxxxxxx > [2] https://lore.kernel.org/all/20231230153159.3748580-1-liujianfeng1994@xxxxxxxxx > > > Changes in v3: > - Drop code in hantro_drv.c because hantro g1 vpu in rk3588 is compatible > with the one in rk3568, only adding devicetree node should work. > - Change devicetree node name to video-codec@fdb50000 to match the reg > address. > - Add dt-bindings rockchip,rk3588-vpu compatible with rockchip,rk3568-vpu > - Link to v2: https://lore.kernel.org/all/20231228131617.3411561-1-liujianfeng1994@xxxxxxxxx > > Jianfeng Liu (2): > arm64: dts: rockchip: Add Hantro G1 VPU support for RK3588 > dt-bindings: media: rockchip-vpu: Add rk3588 vpu compatible string > > .../bindings/media/rockchip-vpu.yaml | 3 +++ > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 20 +++++++++++++++++++ > 2 files changed, 23 insertions(+) >
