Hi Conor, Am Donnerstag, 11. Januar 2024, 17:49:03 CET schrieb Conor Dooley: > On Thu, Jan 11, 2024 at 09:59:54AM +0100, Alexander Stein wrote: > > Hi Conor, > > > > Am Mittwoch, 10. Januar 2024, 17:09:07 CET schrieb Conor Dooley: > > > On Wed, Jan 10, 2024 at 10:43:38AM +0100, Alexander Stein wrote: > > > > Some SoC like i.MX8QXP use a power-domain for this IP add it to the > > > > supported proerties. Fixes the dtbs_check warning: > > > > freescale/imx8qxp-tqma8xqp-mba8xx.dtb: irqsteer@56000000: > > > > 'power-domains' > > > > > > > > does not match any of the regexes: 'pinctrl-[0-9]+' > > > > > > > > from schema $id: > > > > http://devicetree.org/schemas/interrupt-controller/fsl,irqsteer.yaml# > > > > > > > > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx> > > > > --- > > > > > > > > Notes: > > > > Please note that both the board dts and the DT node for irqsteer > > > > being > > > > used, are still work-in-progress. > > > > > > The binding doesn't even support the imx8qxp's irqsteer yet, I think > > > this should be added alongside support for that SoC. Am I missing > > > something? > > > > I'm not sure if any additional SoC support is actually needed. 'fsl,imx- > > irqsteer' is available and that's what I use in my WiP. Also imx8mp also > > just uses the generic compatible. Only imx8mq uses 'fsl,imx8m-irqsteer'. > Why doesn't it used "imx8mq-irqsteer"? Should it not have its own > soc-specific compatible? I would assume that "fsl,imx8m-irqsteer" is for the whole i.MX8M family. I don't think a soc-specific compatible is needed at all. On top I can't see any difference between i.MX8M and i.MX8/i.MX8X. If a soc-specific compatible is preferred, fine by me. But I don't expect any difference despite imx8qxp/imx8qm requiring a power-domain. Best regards, Alexander > Cheers, > Conor. > > > AFAICS the bindings support the different amount of IRQs already. > > > > Best regards, > > Alexander > > > > > > .../devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml | 3 > > > > +++ > > > > 1 file changed, 3 insertions(+) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer. > > > > yam > > > > l > > > > b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer. > > > > yam > > > > l index 20ad4ad82ad64..cb4fcd23627f6 100644 > > > > --- > > > > a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer. > > > > yam > > > > l +++ > > > > b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer. > > > > yam > > > > l> > > > > > > > > @@ -42,6 +42,9 @@ properties: > > > > clock-names: > > > > const: ipg > > > > > > > > + power-domains: > > > > + maxItems: 1 > > > > + > > > > > > > > interrupt-controller: true > > > > > > > > "#interrupt-cells": -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/
