On 17/01/24 2:15 am, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 16/01/2024 12:37, Dharma Balasubiramani wrote: >> Convert the existing DT binding to DT schema of the Atmel's HLCDC display >> controller. >> >> Signed-off-by: Dharma Balasubiramani <dharma.b@xxxxxxxxxxxxx> >> --- >> changelog >> v1 -> v2 >> - Remove the explicit copyrights. >> - Modify filename like compatible. >> - Modify title (drop words like binding/driver). >> - Modify description actually describing the hardware and not the driver. >> - Remove pinctrl properties which aren't required. >> - Ref endpoint and not endpoint-base. >> - Drop redundant info about bus-width description and add ref to video-interfaces. >> - Move 'additionalProperties' after 'Required'. >> - Drop parent node and it's other sub-device node which are not related here. >> - Add compatible to example 2 and add comments that bus-width is the diff between two examples. >> --- > > Please respond to review comments and acknowledge you implement each of > them. I don't think you did here everything I pointed out. The next > patch for sure misses things. My apologies, I will ensure that I address all the review comments in v3. -- With Best Regards, Dharma B. > > Best regards, > Krzysztof >
