On Tue, Jan 16, 2024 at 09:40:21AM +0000, Shengyang Chen wrote: > Hi, Conor > > Thanks for comment. > > > -----Original Message----- > > From: Conor Dooley <conor@xxxxxxxxxx> > > Sent: 2024年1月10日 0:32 > > To: Shengyang Chen <shengyang.chen@xxxxxxxxxxxxxxxx> > > Cc: devicetree@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; > > neil.armstrong@xxxxxxxxxx; quic_jesszhan@xxxxxxxxxxx; sam@xxxxxxxxxxxx; > > airlied@xxxxxxxxx; daniel@xxxxxxxx; maarten.lankhorst@xxxxxxxxxxxxxxx; > > mripard@xxxxxxxxxx; tzimmermann@xxxxxxx; robh+dt@xxxxxxxxxx; > > krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; wahrenst@xxxxxxx; > > dave.stevenson@xxxxxxxxxxxxxxx; thierry.reding@xxxxxxxxx; Changhuang > > Liang <changhuang.liang@xxxxxxxxxxxxxxxx>; Keith Zhao > > <keith.zhao@xxxxxxxxxxxxxxxx>; Jack Zhu <jack.zhu@xxxxxxxxxxxxxxxx>; > > linux-kernel@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add > > compatible property for waveshare 7inch touchscreen panel > > > > On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote: > > > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 > > > panel It can be drived by Raspberry Pi panel's process but it needs > > > different timing from Raspberry Pi panel. Add compatible property for it. > > > > > > Signed-off-by: Keith Zhao <keith.zhao@xxxxxxxxxxxxxxxx> > > > Signed-off-by: Shengyang Chen <shengyang.chen@xxxxxxxxxxxxxxxx> > > > --- > > > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > > index 11422af3477e..02f6b1b2ddc9 100644 > > > --- > > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yam > > > +++ l > > > @@ -335,6 +335,8 @@ properties: > > > - vivax,tpc9150-panel > > > # VXT 800x480 color TFT LCD panel > > > - vxt,vl050-8048nt-c01 > > > + # Waveshare 7" (800x480) touchscreen LCD panel > > > + - waveshare,7inch-touchscreen > > > > Is "7inch-touchscreen" really a specific enough identifier for this device? > > > > Referring to official website[1] and Neil's suggestion, maybe I should change to > "7inch-touchscreen-dsi-lcd" or "waveshare,7inch-dsi-sku19885" if the next patch version is needed. The one with the sku certainly seems more specific, if a next version is needed I would use that. Thanks, Conor.
Attachment:
signature.asc
Description: PGP signature
