Re: [PATCH 5/6] arm64: dts: qcom: qcm2290: declare VLS CLAMP register for USB3 PHY

[Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>]

On 1/16/24 02:08, Dmitry Baryshkov wrote:
> The USB3 PHY on the QCM2290 platform doesn't have built-in
> PCS_MISC_CLAMP_ENABLE register. Instead clamping is handled separately
> via the register in the TCSR space. Declare corresponding register.
>
> Fixes: 0c55f6229bc3 ("arm64: dts: qcom: qcm2290: Add USB3 PHY")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/qcom/qcm2290.dtsi | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi
> index 0911fb08ed63..68b52e8faba5 100644
> --- a/arch/arm64/boot/dts/qcom/qcm2290.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi
> @@ -442,6 +442,11 @@ tcsr_mutex: hwlock@340000 {
>   			#hwlock-cells = <1>;
>   		};
>   
> +		tcsr_regs_1: syscon@360000 {
> +			compatible = "qcom,qcm2290-tcsr", "syscon";
> +			reg = <0x0 0x00360000 0x0 0x20000>;
> +		};
> +
>   		tlmm: pinctrl@500000 {
>   			compatible = "qcom,qcm2290-tlmm";
>   			reg = <0x0 0x00500000 0x0 0x300000>;
> @@ -690,6 +695,8 @@ usb_qmpphy: phy@1615000 {
>   
>   			#phy-cells = <0>;
>   
> +			qcom,tcsr-reg = <&tcsr_regs_1 0x6b244>;

This also leaks outside the syscon space.

Konrad