On 15/01/2024 21:12, Trevor Gamblin wrote: > From: Drew Fustini <dfustini@xxxxxxxxxxxx> > > Add bindings for Analog Devices AXI PWM generator. If there is going to be new version, two things to fix: A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen > Signed-off-by: Drew Fustini <dfustini@xxxxxxxxxxxx> > Co-developed-by: Trevor Gamblin <tgamblin@xxxxxxxxxxxx> > Signed-off-by: Trevor Gamblin <tgamblin@xxxxxxxxxxxx> > --- > .../bindings/pwm/adi,axi-pwmgen.yaml | 48 +++++++++++++++++++ > MAINTAINERS | 8 ++++ > 2 files changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml > new file mode 100644 > index 000000000000..8f16b2e14154 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/adi,axi-pwmgen.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AXI PWM generator > + > +maintainers: > + - Michael Hennerich <Michael.Hennerich@xxxxxxxxxx> > + - Nuno Sá <nuno.sa@xxxxxxxxxx> > + > +description: > + The Analog Devices AXI PWM generator can generate PWM signals > + with variable pulse width and period. > + > + https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen > + > +allOf: > + - $ref: pwm.yaml# > + > +properties: > + compatible: > + const: adi,axi-pwmgen-1.00.a > + > + reg: > + maxItems: 1 > + > + "#pwm-cells": > + const: 2 > + > + clocks: > + maxItems: 1 > + > +unevaluatedProperties: false This goes after "required:" Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
