On Mon, Jan 15, 2024 at 10:57 AM André Draszik <andre.draszik@xxxxxxxxxx> wrote: > > On Mon, 2024-01-15 at 17:37 +0100, Michal Simek wrote: > > > > > > On 1/15/24 17:29, Conor Dooley wrote: > > > On Mon, Jan 15, 2024 at 09:40:37AM +0000, André Draszik wrote: > > > > Hi, > > > > > > > > On Mon, 2024-01-15 at 10:20 +0100, Michal Simek wrote: > > > > > This patch is causing issue for me. Look at log below. > > > > > I am running it directly on the latest linux-next/master. > > > > > > > > > > Thanks, > > > > > Michal > > > > > > > > > > $ make DT_SCHEMA_FILES="Documentation/devicetree/bindings/arm/arm,cci-400.yaml" > > > > > dt_binding_check > > > > > > > > It'll work if you drop the 'Documentation/devicetree/bindings' part from the path, as > > > > it is implied since bindings can only be in that directory anyway: > > > > > > > > make DT_SCHEMA_FILES="arm/arm,cci-400.yaml" dt_binding_check > > > > make DT_SCHEMA_FILES="arm,cci-400.yaml" dt_binding_check > > > > > > > > both work. > > > > > > Requiring that is pretty user unfriendly though I think, passing the > > > full path from the root directory of the kernel tree would be my > > > assumption of the "default". > > > > I am using full path like this for years. > > I just just went by Documentation/devicetree/bindings/writing-schema.rst > which doesn't suggest adding Documentation/devicetree/bindings/. In an > attempt to make it more robust for anybody following this doc, I opted > for the current implementation. It originally worked only with the full tree path. It's now enhanced to take any substring for a match. As that is preferred (and shorter) that's what the documentation has. > > I can fix my scripts but would be good to consider correct path inside the > > kernel is something what this patch should also allow. > > Because path above is correct and it is not outside of the kernel that's why at > > least commit message should be massage a little bit. > > I hear you, and I'll make a v2 to not imply the bindings directory. A follow-up, not a v2 because v1 is already applied. Rob
