On 1/15/24 16:46, Rob Herring wrote:
> On Mon, Jan 15, 2024 at 02:20:04PM +0100, Raphael Gallais-Pou wrote:
>> Add "st,stm32mp25-lvds" compatible.
>>
>> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@xxxxxxxxxxx>
>> ---
>> Depends on: "dt-bindings: stm32: add clocks and reset binding for
>> stm32mp25 platform" by Gabriel Fernandez
>>
>> Changes in v3:
>> - Clarify commit dependency
>> - Fix includes in the example
>> - Fix YAML
>> - Add "clock-cells" description
>> - s/regroups/is composed of/
>> - Changed compatible to show SoC specificity
>>
>> Changes in v2:
>> - Switch compatible and clock-cells related areas
>> - Remove faulty #include in the example.
>> - Add entry in MAINTAINERS
>> ---
>> .../bindings/display/st,stm32-lvds.yaml | 119 ++++++++++++++++++
> Filename matching compatible.
Hi Rob,
I was unsure about this.
The driver will eventually support several SoCs with different compatibles,
wouldn't this be more confusing ?
I also wanted to keep the similarity with the "st,stm32-<ip>.yaml" name for the
DRM STM drivers. Would that be possible ?
Regards,
Raphaël
>
>> +properties:
>> + compatible:
>> + const: st,stm32mp25-lvds
>
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/st,stm32mp25-rcc.h>
>> + #include <dt-bindings/reset/st,stm32mp25-rcc.h>
>> +
>> + lvds: lvds@48060000 {
>> + compatible = "st,stm32-lvds";
> Wrong compatible.
