On Mon, Jan 15, 2024 at 03:58:56PM +0100, Krzysztof Kozlowski wrote: > On 15/01/2024 15:51, KyuHyuk Lee wrote: > > The vendor in ODROID-M1 is hardkernel, but it was incorrectly written > > as rockchip. Fixed the vendor prefix correctly. > > > > Signed-off-by: KyuHyuk Lee <lee@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > You need to start testing your patches. Your last M1 fails as well in > multiple places. > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check W=1` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). > > The DTS change will break the users, so would be nice to mention this in > its commit msg. > > Best regards, > Krzysztof > Hello, Krzysztof. I am truly sorry for wasting your time due to my mistake. >From now on, i will carefully send PATCH with testing. I'm really sorry. Thank you, KyuHyuk Lee.
