On 15.01.24 14:02, Krzysztof Kozlowski wrote: > On 15/01/2024 10:16, Javier Carrasco wrote: >> The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit >> multicore controller for voice processing. >> >> Add new bindings to define the device properties. > > I don't see any bus, so how does it work? How do you get the voice data > from it? I also do not see any DAI: neither here nor in the driver... > The voice data and any other information can be retrieved directly via USB from userspace. Once in normal operation, the device acts as a regular "onboard" USB device and the driver does not need to do any further management. > If there is going to be any new version, then implement all following > comments: > > A nit, subject: drop second/last, redundant "bindings for". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > >> >> [1] https://www.xmos.com/xvf3500/ >> >> Signed-off-by: Javier Carrasco <javier.carrasco@xxxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/sound/xmos,xvf3500.yaml | 51 ++++++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/xmos,xvf3500.yaml b/Documentation/devicetree/bindings/sound/xmos,xvf3500.yaml >> new file mode 100644 >> index 000000000000..e93a735a0f1a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/xmos,xvf3500.yaml >> @@ -0,0 +1,51 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/xmos,xvf3500.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: XMOS XVF3500 VocalFusion Voice Processor >> + >> +maintainers: >> + - Javier Carrasco <javier.carrasco@xxxxxxxxxxxxxx> >> + >> +description: |- > > Do not need '|-' unless you need to preserve formatting. > > >> + The XMOS XVF3500 VocalFusion Voice Processor is a low-latency, 32-bit >> + multicore controller for voice processing. >> + https://www.xmos.com/xvf3500/ >> + >> +properties: >> + compatible: >> + const: xmos,xvf3500 >> + >> + reset-gpios: >> + maxItems: 1 >> + >> + vcc1v0-supply: >> + description: | > > Do not need '|' unless you need to preserve formatting. > > >> + Regulator for the 1V0 supply. >> + >> + vcc3v3-supply: >> + description: | > > Do not need '|' unless you need to preserve formatting. > >> + Regulator for the 3V3 supply. >> + >> +additionalProperties: false > > This goes after required: block. > >> + >> +required: >> + - compatible >> + - reset-gpios >> + - vcc1v0-supply >> + - vcc3v3-supply >> + >> +examples: >> + - | >> + #include <dt-bindings/gpio/gpio.h> >> + >> + xvf3500: voice-processor { > > Drop unused label. > > > > Best regards, > Krzysztof > Thank you for your feedback and best regards, Javier Carrasco
