Il 12/01/24 15:20, Nícolas F. R. A. Prado ha scritto:
The cbas node is used to describe base detection functionality in the
ChromeOS EC, which is used for units that have a detachable keyboard and
thus rely on this functionality to switch between tablet and laptop
mode.
All machines in the jacuzzi family are either clamshells (ie normal
laptops) or convertibles, meaning the keyboard can be flipped but not
detached. The detection for the keyboard getting flipped is handled by
the driver bound to the keyboard-controller node in the EC.
Since there is no base detection in these machines, and the device
backed by this node fails to probe and goes unused, delete the node from
the DT.
Fixes: 4fa8492d1e5b ("arm64: dts: mt8183: add cbas node under cros_ec")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
I really don't like seeing /delete-node/ statements, unless there's an
exceptionally good reason to do so, and I don't think this is the case.
Please remove cbas from the base inclusion and add it on a per-device basis.
Thanks,
Angelo
