Hi, Geert, On 12.01.2024 18:20, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Fri, Jan 12, 2024 at 4:38 PM claudiu beznea <claudiu.beznea@xxxxxxxxx> wrote: >> On 12.01.2024 15:55, Geert Uytterhoeven wrote: >>> On Wed, Dec 27, 2023 at 2:08 PM Claudiu <claudiu.beznea@xxxxxxxxx> wrote: >>>> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> >>>> >>>> RZ SMARC Carrier II board has 3 user buttons called USER_SW1, USER_SW2, >>>> USER_SW3. Add a DT node in device tree to propertly instantiate the >>>> gpio-keys driver for these buttons. >>>> >>>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> >>> >>> Thanks for your patch! >>> >>>> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi >>>> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi >>>> @@ -14,6 +15,37 @@ aliases { >>>> mmc1 = &sdhi1; >>>> }; >>>> >>>> + keys { >>> >>> Do you mind if I s/keys/keypad/ while applying? ... >> >> Is not actually a keypad... there are 3 buttons in a corner of the board... >> >> I see only 2 entries in arm64 and arm DTS directory following this pattern >> for gpio-keys compatible node: >> >> arch/arm/boot/dts/renesas/r8a7779-marzen.dts >> arch/arm/boot/dts/renesas/r8a7779-marzen.dts >> >> But if you prefer it like this, I have nothing against. >> >> Just asking, do you have a particular reason for naming it like this? > > See the discussion in [1], and the resulting patch[2], which added the > (so far) single user in arch/arm/boot/dts/renesas/r8a7779-marzen.dts > > [1] https://lore.kernel.org/all/20231023144134.1881973-1-geert+renesas@xxxxxxxxx Ah, I remember part of this discussion. Good for me to rename it as you proposed. > [2] https://lore.kernel.org/all/eec1ccfb75c6215428609fdcaf3a37c75fe1fc87.1698228163.git.geert+renesas@xxxxxxxxx >> >>>> + interrupt-parent = <&pinctrl>; >>> >>> ... and move these one level up, to avoid duplication? >> >> Moving it just near compatible will make the schema validation to fail with >> this (driver is working, though): >> >> arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: keys: >> 'interrupt-parent' does not match any of the regexes: >> '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', >> 'pinctrl-[0-9]+' >> from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml# > > Oops, I had completely forgotten r8a7779-marzen.dts triggers this, too... > Let's keep it for now. > > Gr{oetje,eeting}s, > > Geert >