Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Friday, January 5, 2024 3:24 PM > To: Linu Cherian <lcherian@xxxxxxxxxxx>; suzuki.poulose@xxxxxxx; > mike.leach@xxxxxxxxxx; james.clark@xxxxxxx; leo.yan@xxxxxxxxxx > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; coresight@xxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; Sunil Kovvuri Goutham > <sgoutham@xxxxxxxxxxx>; George Cherian <gcherian@xxxxxxxxxxx>; Rob > Herring <robh@xxxxxxxxxx> > Subject: [EXT] Re: [PATCH v6 1/7] dt-bindings: arm: coresight-tmc: Add > "memory-region" property > > External Email > > ---------------------------------------------------------------------- > On 05/01/2024 06:58, Linu Cherian wrote: > > memory-region 0: Reserved trace buffer memory > > > > TMC ETR: When available, use this reserved memory region for > > trace data capture. Same region is used for trace data > > retention after a panic or watchdog reset. > > > > TMC ETF: When available, use this reserved memory region for > > trace data retention synced from internal SRAM after a panic or > > watchdog reset. > > > > memory-region 1: Reserved meta data memory > > > > TMC ETR, ETF: When available, use this memory for register > > snapshot retention synced from hardware registers after a panic > > or watchdog reset. > > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > ... > > > + memory-region: > > + items: > > + - description: Reserved trace buffer memory for ETR and ETF sinks. > > + For ETR, this reserved memory region is used for trace data capture. > > + Same region is used for trace data retention as well after a panic > > + or watchdog reset. > > + This reserved memory region is used as trace buffer or used for > trace > > + data retention only if specifically selected by the user in sysfs > > + interface. > > + The default memory usage models for ETR in sysfs/perf modes are > > + otherwise unaltered. > > + > > + For ETF, this reserved memory region is used by default for > > + retention of trace data synced from internal SRAM after a panic > > + or watchdog reset. > > + - description: Reserved meta data memory. Used for ETR and ETF sinks > > + for storing metadata. > > If there is going to be new version/resend, add a blank line here. Keep the Rb > tag. > Okay. Will take care in next version. Linu Cherian.
