On 12/01/2024 17:58, Conor Dooley wrote: > On Fri, Jan 12, 2024 at 10:42:30PM +0900, KyuHyuk Lee wrote: >> Add device tree binding for Hardkernel ODROID-M1S board based on >> RK3566 SoC. >> >> Signed-off-by: KyuHyuk Lee <lee@xxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml >> index 5cf5cbef2cf5..cc37d2118131 100644 >> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml >> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml >> @@ -566,6 +566,11 @@ properties: >> - const: rockchip,rk3568-odroid-m1 >> - const: rockchip,rk3568 >> >> + - description: Hardkernel Odroid M1S > > if the vendor for this board is hardkernel... > >> + items: >> + - const: rockchip,rk3566-odroid-m1s > > ...why is the vendor prefix here rockchip? Uh, good catch. I missed it when acking their earlier mistake year ago :( Would be nice if they fixed that one too. Best regards, Krzysztof