On 11/01/2024 17:19, Catalin Popescu wrote: > Add property ti,cfg-dac-minus to allow for voltage tuning > of logical level -1 of the MLT-3 encoded data. A nit, subject: drop second/last, redundant "binding". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > Signed-off-by: Catalin Popescu <catalin.popescu@xxxxxxxxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/net/ti,dp83822.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) Don't add properties one by one. Especially if they are related. > > diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml > index db74474207ed..2f010333be49 100644 > --- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml > +++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml > @@ -62,6 +62,15 @@ properties: > for the PHY. The internal delay for the PHY is fixed to 3.5ns relative > to transmit data. > > + ti,cfg-dac-minus: > + description: | > + DP83826 PHY only. > + Sets the voltage ratio of the logical level -1 for the MLT-3 encoded data. ratio between what and what? > + 0 = 50%, 1 = 56.25%, 2 = 62.50%, 3 = 68.75%, 4 = 75%, 5 = 81.25%, 6 = 87.50%, > + 7 = 93.75%, 8 = 100%, 9 = 106.25%, 10 = 112.50%, 11 = 118.75%, 12 = 125%, > + 13 = 131.25%, 14 = 137.50%, 15 = 143.75%, 16 = 150%. > + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16] Missing: "default:" > Best regards, Krzysztof
