On Thu Jan 11, 2024 at 3:57 PM CET, Linus Walleij wrote: > On Wed, Jan 10, 2024 at 4:14 PM Luca Weiss <luca.weiss@xxxxxxxxxxxxx> wrote: > > > Add support for the 2340x1080 LCD DJN panel bundled with a HX83112A > > driver IC, as found on the Fairphone 4 smartphone. > > > > Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx> > > This makes it sound like the Himax HX83112A is the driver IC. > > This does not seem to be the case: > https://github.com/HimaxSoftware/HX83112_Android_Driver > > The driver IC seems to be a truly 5p65. Hi Linus, In some internal documentation it says "LCD Driver IC" "HX83112A" and I don't see any reference to Truly 5P65 anywhere. On their website they have this sentence: Himax offers display drivers for mobile handset displays that combine source driver, gate driver, timing controller, frame buffer, and DC to DC circuits into a single chip in various display technologies, such as TFT-LCD, LTPS, In-Cell Touch and AMOLED. https://www.himax.com.tw/products/display-drivers/mobile-handset-applications/ While I'm not super well versed in panel driver ICs, this sounds like it should be the one to take the name from? Regards Luca > > If this is right, could you rename the driver file to truly-5p65.c > and all symbols containing hx83112 to truly_5965 or something > that indicate the driver IC instead of the panel? > > My main concern is that the next display using the same IC > need to find the right file to patch. > > Yours, > Linus Walleij