On Wed, Jan 10, 2024 at 02:35:30PM +0800, Jason-JH.Lin wrote: > 1. Add "Provider" to the title to make it clearer. > 2. Add reference to gce-props.yaml for adding mediatek,gce-events property. I can see this from the diff. There's still no explanation here as to why the mailbox provider needs to have a gce-event id. NAK until you can explain that. Cheers, Conor. > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx> > --- > .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml > index cef9d7601398..728dc93117a6 100644 > --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml > +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/mailbox/mediatek,gce-mailbox.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Mediatek Global Command Engine Mailbox > +title: MediaTek Global Command Engine Mailbox Provider > > maintainers: > - Houlong Wei <houlong.wei@xxxxxxxxxxxx> > @@ -57,6 +57,8 @@ required: > - clocks > > allOf: > + - $ref: mediatek,gce-props.yaml > + > - if: > not: > properties: > @@ -67,7 +69,7 @@ allOf: > required: > - clock-names > > -additionalProperties: false > +unevaluatedProperties: false > > examples: > - | > -- > 2.18.0 >
Attachment:
signature.asc
Description: PGP signature
