Hi, Krzysztof, On Tue, Jan 9, 2024 at 11:13 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 09/01/2024 16:02, Huacai Chen wrote: > >>>>> Applied to loongarch-next, thanks. > >>>>> > >>>> > >>>> It's merge window, why do you apply patches? For which cycle? > >>> I'm sorry I forgot to reply to the email when I applied patches, the > >>> patches have already been pulled in linux-next some days before. > >> > >> Really? I cannot find them on next-20240108, so what happened? > > Hmm, I applied patches two days ago, and they were only pulled in next-20240109. > > Two days ago is weekend, so basically one day ago and definitely not > "some days before". > > Anyway two days ago merge window started, so it means you applied them > during the merge window or immediately before. That's not good. Patches > should be in linux-next BEFORE. > > > > >> > >> Are you aware that patches should be in next for "few next cycles" > >> minimum (which means few days or even a week)? > > Thank you for your reminder, when I sent my first PR, my mentor had > > already told me this. So I will wait until next week to send PR for > > this series. > > In the future, please be sure that all your patches for next PR are for > several days in your for-next branch, thus at least for few linux-next > cycles. OK, I will obey this rule strictly. Thanks. Huacai > > > Best regards, > Krzysztof >