Hi Krzysztof, Am Dienstag, 9. Januar 2024, 16:15:30 CET schrieb Krzysztof Kozlowski: > On 09/01/2024 14:35, Quentin Schulz wrote: > > From: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxxxxx> > > > > There are 6 SPI controllers on RK3399 and they are all numbered in the > > TRM, so let's add the appropriate aliases to the main DTSI so that any > > RK3399-based board doesn't need to define the aliases themselves to > > benefit from stable SPI indices in userspace. > > But that contradicts the point that board should define aliases for > exposable interfaces. Sorry, that's a NAK. didn't we have this same discussion some weeks ago? ;-) . I.e. spi2 on Rockchip socs is called spi2 in _all_ SoC documentation, lines in _all_ schematics are also always called spi2_foo , so as before I really don't see any value in repeating the very same aliases in _every_ board. Same for i2c, uart . It is of course different for non-numerable interfaces - like the mmcX aliases - where the controller is named sdhci, sdmmc, sdio ... and similar cases. These get to stay in the board dts files of course. Heiko > > Cc: Quentin Schulz <foss+kernel@xxxxxxxxx> > > No need to Cc yourself... > > > Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxxxxx> > > --- > > Best regards, > Krzysztof > >
