>-----Original Message----- >From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >Sent: Monday, January 8, 2024 3:38 PM >To: Ritesh Kumar (QUIC) <quic_riteshk@xxxxxxxxxxx>; dri- >devel@xxxxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- >kernel@xxxxxxxxxxxxxxx >Cc: neil.armstrong@xxxxxxxxxx; Jessica Zhang (QUIC) ><quic_jesszhan@xxxxxxxxxxx>; sam@xxxxxxxxxxxx; >maarten.lankhorst@xxxxxxxxxxxxxxx; mripard@xxxxxxxxxx; >tzimmermann@xxxxxxx; airlied@xxxxxxxxx; daniel@xxxxxxxx; >robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; >Abhinav Kumar (QUIC) <quic_abhinavk@xxxxxxxxxxx>; Rajeev Nandan (QUIC) ><quic_rajeevny@xxxxxxxxxxx>; Vishnuvardhan Prodduturi (QUIC) ><quic_vproddut@xxxxxxxxxxx>; sumit.semwal@xxxxxxxxxx >Subject: Re: [v2 1/2] dt-bindings: display: panel: Add Novatek NT36672E LCD >DSI > >On 08/01/2024 10:59, Ritesh Kumar wrote: >> Document Novatek NT36672E FHD+ LCD DSI panel. >> >> Signed-off-by: Ritesh Kumar <quic_riteshk@xxxxxxxxxxx> >> >> --- >> v2: Fixed review comments from Krzysztof > >Please use standard email subjects, so with the PATCH keyword in the title. `git >format-patch` helps here to create proper versioned patches. >Another useful tool is b4. Skipping the PATCH keyword makes filtering of emails >more difficult thus making the review process less convenient. I am using git format-patch only. I think the name of series is changed causing the trouble. > >> - renamed to novatek,nt36672e, since the binding is for the IC and >> not the panel. >> - moved additionalProperties after required. >> --- >> .../display/panel/novatek,nt36672e.yaml | 66 +++++++++++++++++++ >> 1 file changed, 66 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yaml >> >> diff --git >> >a/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yam >> l >> >b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e.yam >> l >> new file mode 100644 >> index 000000000000..dc4672f3d01d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672e >> +++ .yaml >> @@ -0,0 +1,66 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 >> +--- >> +$id: >> +http://devicetree.org/schemas/display/panel/novatek,nt36672e.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Novatek NT36672E LCD DSI Panel >> + >> +maintainers: >> + - Ritesh Kumar <quic_riteshk@xxxxxxxxxxx> >> + >> +allOf: >> + - $ref: panel-common.yaml# >> + >> +properties: >> + compatible: >> + const: novatek,nt36672e >> + >> + reg: >> + maxItems: 1 >> + description: DSI virtual channel >> + >> + vddi-supply: true >> + avdd-supply: true >> + avee-supply: true > >Are these names of pins? Somehow I have troubles believing that NT36672A >and NT36672E have entirely different names for these... Yes, these are name of pins. Below is the Pin Description from NT36672E Datasheet: vddi - Power supply to the I/O. avdd - Positive input analog power for driver IC use. avee - Negative input analog power for driver IC use. I could not find datasheet of NT36672A online to compare the names. Thanks, Ritesh
