On Thu, 28 Dec 2023, Rafał Miłecki wrote: > Hi Lee, > > On 16.03.2023 16:33, Lee Jones wrote: > > On Thu, 16 Mar 2023, Rafał Miłecki wrote: > > > > > From: Rafał Miłecki <rafal@xxxxxxxxxx> > > > > > > Linux's "usbport" trigger is a bit specific one. It allows LED to follow > > > state of multiple USB ports which have to be selected additionally > > > (there isn't a single trigger for each port). > > > > > > Default list of USB ports to monitor can be specified using > > > "trigger-sources" DT property. Theoretically it should be possible for > > > Linux to deduce applicable trigger based on the references nodes in the > > > "trigger-sources". It hasn't been implemented however (probably due to > > > laziness). > > > > > > Milk spilled - we already have DT files specifying "usbport" manually - > > > allow that value in the binding. This fixes validation of in-kernel and > > > external DT files. > > > > > > Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx> > > > --- > > > Documentation/devicetree/bindings/leds/common.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Applied, thanks > > it seems this PATCH got lost somewhere. Can you check it, please? What makes you think that? https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/leds/common.yaml#L126 -- Lee Jones [李琼斯]