On Fri, Jan 05, 2024 at 05:18:45AM -0800, Emil Renner Berthing wrote: > Uwe Kleine-König wrote: > > Hello Emil, > > > > On Sun, Dec 24, 2023 at 02:49:34AM -0800, Emil Renner Berthing wrote: > > > William Qiu wrote: > > > > Add OpenCores PWM controller node and add PWM pins configuration > > > > on VisionFive 1 board. > > > > > > > > Signed-off-by: William Qiu <william.qiu@xxxxxxxxxxxxxxxx> > > > > > > Sorry, I thought I already sent my review. This looks good. > > > > > > Reviewed-by: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx> > > > > Is this also an implicit Ack to take this patch via the pwm tree once > > the earlier patches are ready? Or do you want to take it via your tree? > > (Maybe already now together with the binding? If so, you can assume my > > Reviewed-by to be an implicit Ack for that.) > > Yes, sorry. This is also meant to be an Ack from me. > > I imagined the dt patches would go through Conor's riscv-dt-for-next branch, > but the pwm tree is certainly also fine by. idk, I prefer things to go as MAINTAINERS indicates, in case something is determined to be wrong in the cycle where the patch is in the "wrong" tree. I suppose I could take the binding though, since I am CCed on every binding patch under the sun... I'd rather an explicit ack in that case though. Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature