On 08/01/2024 10:00, Jingbao Qiu wrote: > On Mon, Jan 8, 2024 at 4:02 PM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 08/01/2024 08:22, Jingbao Qiu wrote: >>> Real Time Clock (RTC) is an independently powered module >>> within the chip, which includes a 32KHz oscillator and >>> a Power On Reset/POR submodule. It can be used for time >>> display and timed alarm generation. >>> >>> Power On Reset/POR submodule only using register resources >>> so it should be empty. The 32KHz oscillator only provides >>> pulses for RTC in hardware. >>> >>> >>> Changes since v4: >>> - remove POR dt-bindings because it empty >>> - remove MFD dt-bindings because SoC does >>> not have MFDs >>> - add syscon attribute to share registers >>> with POR >>> >>> v4: https://lore.kernel.org/all/20231229090643.116575-1-qiujingbao.dlmu@xxxxxxxxx/ >>> >>> Changes since v3: >>> - temporarily not submitting RTC driver code >>> waiting for communication with IC designer >> >> Hm, why? >> >> We do not need bindings if nothing matches to them. If this binding is >> for other upstream open-source project, please provide references. >> >> See also: >> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L61 >> > > Hi! > > There is a function in the RTC driver code used to calibrate the > clock, which is define in the datasheet. > However, Alexandre Belloni raised concerns that clock calibration > should be done using GPS or similar > methods, rather than using other clock sources. I think what he said > makes sense. So it is necessary > to communicate with IC designers. > > link: https://lore.kernel.org/all/202312271350242a208426@mail.local/ Sure, this I get, but why sending bindings alone? There is no user of them. Best regards, Krzysztof
