On 28/12/2023 10:39, Karel Balej wrote: > diff --git a/drivers/mfd/88pm88x.c b/drivers/mfd/88pm88x.c > index 69a8e39d43b3..999d0539b720 100644 > --- a/drivers/mfd/88pm88x.c > +++ b/drivers/mfd/88pm88x.c > @@ -68,6 +68,21 @@ static struct mfd_cell pm886_devs[] = { > .num_resources = ARRAY_SIZE(pm88x_onkey_resources), > .resources = pm88x_onkey_resources, > }, > + { > + .name = "88pm88x-regulator", > + .id = PM88X_REGULATOR_ID_LDO2, > + .of_compatible = "marvell,88pm88x-regulator", > + }, > + { > + .name = "88pm88x-regulator", > + .id = PM88X_REGULATOR_ID_LDO15, > + .of_compatible = "marvell,88pm88x-regulator", > + }, > + { > + .name = "88pm88x-regulator", > + .id = PM886_REGULATOR_ID_BUCK2, > + .of_compatible = "marvell,88pm88x-regulator", Same compatible per each regulator looks suspicious, if not even wrong. What are these? Best regards, Krzysztof