On 04/01/2024 19:12, Daniel Golle wrote: > Hi Frank, > > On Thu, Jan 04, 2024 at 06:39:29PM +0100, Frank Wunderlich wrote: >> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> >> >> --- >> include/dt-bindings/reset/mediatek,mt7988-resets.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/include/dt-bindings/reset/mediatek,mt7988-resets.h b/include/dt-bindings/reset/mediatek,mt7988-resets.h >> index 493301971367..3f1e4ec07ad5 100644 >> --- a/include/dt-bindings/reset/mediatek,mt7988-resets.h >> +++ b/include/dt-bindings/reset/mediatek,mt7988-resets.h >> @@ -10,4 +10,8 @@ >> /* ETHWARP resets */ >> #define MT7988_ETHWARP_RST_SWITCH 0 >> >> +/* INFRA resets */ >> +#define MT7988_INFRA_RST0_THERM_CTRL_SWRST 9 > > I suppose this argument applies here as well: > > "IDs should start from 0 or 1 and increment by 1. If these are not IDs, > then you do not need them in the bindings." > > https://lore.kernel.org/all/59629ec1-cc0c-4c5a-87cc-ea30d64ec191@xxxxxxxxxx/ > > As a consequence, as what you are describing there are hardware bits If this is existing driver which already uses such pattern, then it is fine. I usually comment this on new drivers which can be changed. Best regards, Krzysztof
