On Thu Jan 4, 2024 at 6:50 PM EET, Jarkko Sakkinen wrote: > On Tue Jan 3, 2023 at 5:51 PM EET, Lukas Wunner wrote: > > Commit 4f2a348aa365 ("arm64: dts: imx8mm-venice-gw73xx: add TPM device") > > added a devicetree node for the Trusted Platform Module on certain > > Gateworks boards. > > > > The commit only used the generic "tcg,tpm_tis-spi" compatible string, > > but public documentation shows that the chip is an ATTPM20P from Atmel > > (nowadays Microchip): > > https://trac.gateworks.com/wiki/tpm > > > > Add the chip to the supported compatible strings of the TPM TIS SPI > > schema. > > > > For reference, a datasheet is available at: > > https://ww1.microchip.com/downloads/en/DeviceDoc/ATTPM20P-Trusted-Platform-Module-TPM-2.0-SPI-Interface-Summary-Data-Sheet-DS40002082A.pdf > > > > Signed-off-by: Lukas Wunner <lukas@xxxxxxxxx> > > Cc: Tim Harvey <tharvey@xxxxxxxxxxxxx> > > --- > > This patch depends on the following series to consolidate TCG TIS bindings: > > https://lore.kernel.org/all/cover.1702806810.git.lukas@xxxxxxxxx/ > > > > Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml b/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml > > index c3413b4..6cb2de7 100644 > > --- a/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml > > +++ b/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml > > @@ -20,6 +20,7 @@ properties: > > compatible: > > items: > > - enum: > > + - atmel,attpm20p > > - infineon,slb9670 > > - st,st33htpm-spi > > - st,st33zp24-spi > > Acked-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx> meant: Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx> I can pick this if no objections. BR, Jarkko