On 04/01/2024 12:33, Bryan O'Donoghue wrote: > On 03/01/2024 17:54, Rob Herring wrote: >> On Wed, Jan 03, 2024 at 09:40:02AM +0000, Bryan O'Donoghue wrote: >>> On 03/01/2024 07:40, Krzysztof Kozlowski wrote: >>>> On 03/01/2024 03:18, Bryan O'Donoghue wrote: >>>>> Add bindings for qcom,sc8280xp-camss in order to support the camera >>>>> subsystem for sc8280xp as found in the Lenovo x13s Laptop. >>>>> >>>>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> >>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >>>>> --- >>>>> .../bindings/media/qcom,sc8280xp-camss.yaml | 512 +++++++++++++++++++++ >>>>> 1 file changed, 512 insertions(+) >>>>> >>>> >>>> This patch fails, as pointed out by Robot. >>>> >>>> Best regards, >>>> Krzysztof >>>> >>>> >>> >>> Ah its in Bjorn's 6.8 clock pull tree. >>> >>> I will repost when it hits -next >> >> How is that helpful? It will still fail, and the media maintainers still >> can't apply this. If you work on linux-next, you'd better be >> aware of and explain the dependencies. >> >> Rob > > Well, it actually is in -next as at the time I posted this patch linux-next is not a tree of one maintainer. Maintainer's cannot base their trees on linux-next. > > https://git.codelinaro.org/bryan.odonoghue/kernel/-/blob/linux-next-24-01-02-sc8280xp-camss-core-dtsi/include/dt-bindings/clock/qcom,sc8280xp-camcc.h > > per the branch referenced in the cover letter Cover letter does not say anything about this depending on the patch in linux-next or in any other tree. > > https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-24-01-02-sc8280xp-camss-core-dtsi > > Looking at the name of the branch for your bot > > 20240103-linux-next-24-01-02-sc8280xp-camss-core-dtsi-v1-1-abacaa63a961@xxxxxxxxxx That's your message ID. > > Does this branch name in the bot output > "linux-next-24-01-02-sc8280xp-camss-core-dtsi-v1" imply it built from > the branch I referenced in the cover letter > "linux-next-24-01-02-sc8280xp-camss-core-dtsi" ? > > Am I getting the base of the build right ? > > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240103-linux-next-24-01-02-sc8280xp-camss-core-dtsi-v1-1-abacaa63a961@xxxxxxxxxx/ > > If not - what is the base of the build ? master Anyway, the base of the build matters less. The main problem is that you have dependency which is nowhere explained. This cannot go via media tree, because of that dependency. Best regards, Krzysztof
