On 04/01/2024 10:26, Chunyan Zhang wrote: >>>> Missing names. >>> >>> The names are fixed, but the order are not. >> >> Order must be fixed. Did you read this? It must be. If it is not, your patchset has issues you must fix. >> >>> >>> For example: >>> clk_a { >>> clocks = <&ext_26m>, <&ext_32k>; >>> clock-names = "ext-26m", "ext-32k"; >>> }; >>> >>> clk_b { >>> clocks = <&ext_26m>, <&ext_4m>; >>> clock-names = "ext-26m", "ext-4m"; >> >> And here the order is fixed... > > The order is not fixed, 'clk_b' will cause dtb_check error, since it > skips the second one i.e. ext-32k in the clock-names list. Then why do you use the same compatible for two different devices? Best regards, Krzysztof