Hi Lukas, On Wed, Jan 03, 2024 at 01:45:02PM +0100, Lukas Wunner wrote: > On Tue, Jan 02, 2024 at 04:11:28PM -0800, Tao Ren wrote: > > On Wed, Dec 20, 2023 at 09:14:02AM +0100, Lukas Wunner wrote: > > > On Thu, Aug 05, 2021 at 03:28:15PM -0700, rentao.bupt@xxxxxxxxx wrote: > > > > This common descirption is included by all Facebook AST2600 Network BMC > > > > platforms to minimize duplicated device entries across Facebook Network > > > > BMC device trees. > > > [...] > > > > --- /dev/null > > > > +++ b/arch/arm/boot/dts/ast2600-facebook-netbmc-common.dtsi > > > [...] > > > > + tpmdev@0 { > > > > + compatible = "tcg,tpm_tis-spi"; > > > > > > What's the chip used on this board? Going forward, the DT schema for TPMs > > > requires the exact chip name in addition to the generic "tcg,tpm_tis-spi". > > > > Sorry about the late response. It's "infineon,slb9670", and I will > > submit a patch for fix it soon. > > Thank you Tao and Patrick for the replies. I've prepared two commits > to fix all violations of the TPM schema on this branch: > > https://github.com/l1k/linux/commits/tpm-dt3 > > The commits are named: > > e95bdbc arm64: dts: Fix TPM schema violations > 63e5dfd ARM: dts: Fix TPM schema violations > > I've now amended the ARM commit to use "infineon,slb9670" for: > > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-wedge400.dts > arch/arm/boot/dts/aspeed/ast2600-facebook-netbmc-common.dtsi > > I intend to submit the two commits once the TPM schema is applied > either to Jarkko's or Rob's tree: > > https://lore.kernel.org/all/20231220160422.GA282877-robh@xxxxxxxxxx/ > > Thanks, > > Lukas I've confirmed it's "infineon,slb9670" for both wedge400 and ast2600-facebook-netbmc-common. Pleasr free to add to "63e5dfd (ARM: dts: Fix TPM schema violations)": Reviewed-by: Tao Ren <rentao.bupt@xxxxxxxxx> Cheers, - Tao