Hi Krzysztof,
>> Add the YAML documentation for Realtek DHC (Digital Home Center) SoCs.
>>
>> Signed-off-by: James Tai <james.tai@xxxxxxxxxxx>
>
>Thank you for your patch. There is something to discuss/improve.
>
>> + interrupts:
>> + minItems: 1
>> + maxItems: 3
>> + description:
>> + Contains the GIC SPI IRQs mapped to the external interrupt lines.
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupt-controller
>> + - '#interrupt-cells'
>> + - '#address-cells'
>> + - interrupts
>> +
>> +additionalProperties: false
>> +
>> +allOf:
>
>If there is going to be new version/resend, allOf: block goes before
>additionalProperties:.
>
I will move the 'allOf: block' to go before 'additionalPropertie' in next patches.
>> + - $ref: /schemas/interrupt-controller.yaml#
>> + - if:
>> + properties:
>> + compatible:
>> + enum:
>> + - realtek,rtd1319-intc-iso
>> + then:
>> + properties:
>> + interrupts:
>> + minItems: 1
>
>Why the second interrupt is optional? It's a SoC, the pins are not configurable
>usually. Same question for other cases.
>
I thought it was defined this way to accommodate different SoCs.
I will remove the 'minItems'. Should the correct version look like the following?
allOf:
- $ref: /schemas/interrupt-controller.yaml#
- if:
properties:
compatible:
enum:
- realtek,rtd1319-intc-iso
then:
properties:
interrupts:
items:
- description: isolation irqs
- description: rtc irq
...
...
Thanks for your feedback.
Regards,
James
